feat: wallet full batchability #19652
Merged
+202
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benesjan
reviewed
Jan 16, 2026
Contributor
benesjan
left a comment
benesjan
left a comment
There was a problem hiding this comment.
Looks good 👍
BTW I just merged my router contract renaming PR so you will need to update the exports here
| /** | ||
| * Creates batch schemas from the individual wallet methods | ||
| * This allows us to define them once and derive batch schemas automatically, | ||
| * reducing duplication and ensuring consistency. |
Contributor
There was a problem hiding this comment.
The 120 chars are extra smol here 🧐
Contributor
Author
There was a problem hiding this comment.
I don't follow, this comment is 78 chars long at a max?
Contributor
There was a problem hiding this comment.
I mean that I would expect you to wrap at 120 but it's just a detail
AztecBot
force-pushed
the
gj/wallet_full_batchability
branch
from
13f87b0 to
413d3d9
Compare
AztecBot
force-pushed
the
gj/wallet_full_batchability
branch
from
413d3d9 to
2c4f14c
Compare
Allows ALL methods in the wallet to be batched (because why not). Initially I was going for allowing them on a case-by-case basis, but integrating the Wallet SDK has made apparent apps can have many interaction flows and this extra flexibility is nice. Updated the migration notes and in the process realized I missed exporting some artifacts in #19457, so here they are (protocol contract wrappers) Co-authored-by: thunkar <[email protected]>
AztecBot
force-pushed
the
gj/wallet_full_batchability
branch
from
4765c91 to
aa3d3bd
Compare
benesjan
approved these changes
Jan 19, 2026
Collaborator
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows ALL methods in the wallet to be batched (because why not). Initially I was going for allowing them on a case-by-case basis, but integrating the Wallet SDK has made apparent apps can have many interaction flows and this extra flexibility is nice.
Updated the migration notes and in the process realized I missed exporting some artifacts in #19457, so here they are (protocol contract wrappers)